Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "authn: Add NewConfigKeychain to load a config from explicit path" #1664

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

imjasonh
Copy link
Collaborator

Reverts #1603

Fixes #1662

@codecov-commenter
Copy link

Codecov Report

Merging #1664 (82c07cb) into main (217318c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1664      +/-   ##
==========================================
- Coverage   72.00%   71.98%   -0.02%     
==========================================
  Files         119      119              
  Lines        9653     9625      -28     
==========================================
- Hits         6951     6929      -22     
+ Misses       1996     1992       -4     
+ Partials      706      704       -2     
Impacted Files Coverage Δ
pkg/authn/keychain.go 94.49% <100.00%> (+5.44%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh merged commit 27a6ad6 into main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crane: Latest version of debug image broke crane cp
3 participants