Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate estargz #1660

Merged
merged 3 commits into from
Apr 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Over time, we will add new functionality under experimental environment variable

| Env Var | Value(s) | What is does |
|---------|----------|--------------|
| `GGCR_EXPERIMENT_ESTARGZ` | `"1"` | When enabled this experiment will direct `tarball.LayerFromOpener` to emit [estargz](https://github.com/opencontainers/image-spec/issues/815) compatible layers, which enable them to be lazily loaded by an appropriately configured containerd. |
| `GGCR_EXPERIMENT_ESTARGZ` | `"1"` | ⚠️DEPRECATED⚠️: When enabled this experiment will direct `tarball.LayerFromOpener` to emit [estargz](https://github.com/opencontainers/image-spec/issues/815) compatible layers, which enable them to be lazily loaded by an appropriately configured containerd. |


### `v1.Image`
Expand Down
42 changes: 0 additions & 42 deletions cmd/crane/cmd/optimize.go

This file was deleted.

1 change: 0 additions & 1 deletion cmd/crane/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ func New(use, short string, options []crane.Option) *cobra.Command {
NewCmdList(&options),
NewCmdManifest(&options),
NewCmdMutate(&options),
NewCmdOptimize(&options),
NewCmdPull(&options),
NewCmdPush(&options),
NewCmdRebase(&options),
Expand Down
3 changes: 0 additions & 3 deletions pkg/crane/crane_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,6 @@ func TestBadInputs(t *testing.T) {
{"Tag(invalid, invalid)", crane.Tag(invalid, invalid)},
{"Tag(404, invalid)", crane.Tag(valid404, invalid)},
{"Tag(404, 404)", crane.Tag(valid404, valid404)},
{"Optimize(invalid, invalid)", crane.Optimize(invalid, invalid, []string{})},
{"Optimize(404, invalid)", crane.Optimize(valid404, invalid, []string{})},
{"Optimize(404, 404)", crane.Optimize(valid404, valid404, []string{})},
// These return multiple values, which are hard to use as expressions.
{"Pull(invalid)", e(crane.Pull(invalid))},
{"Digest(invalid)", e(crane.Digest(invalid))},
Expand Down
237 changes: 0 additions & 237 deletions pkg/crane/optimize.go

This file was deleted.

Loading