Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate estargz #1660

Merged
merged 3 commits into from
Apr 19, 2023
Merged

deprecate estargz #1660

merged 3 commits into from
Apr 19, 2023

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Apr 18, 2023

It's unclear whether this is practically taken advantage of at runtime, since it's relatively hard to run the estargz snapshotter.

There are some callers of this method out in the wild: https://github.com/search?type=code&auto_enroll=true&q=tarball.WithEstargz

If this is useful to others it may make sense to fork it into a separate repo that's capable of producing layers with estargz-optimized tarballs, but this probably isn't something we're going to maintain going forward.

This also removes the previously-hidden crane optimize command, and crane.Optimize, which had a big scary warning about it changing without warning. crane optimize only seems to be used in forks of Matt's mink repo, and crane.Optimize only seems to be used in forks of ggcr.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #1660 (bd0efb7) into main (1cb7e13) will increase coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head bd0efb7 differs from pull request most recent head c113d38. Consider uploading reports for the commit c113d38 to get more accurate results

@@            Coverage Diff             @@
##             main    #1660      +/-   ##
==========================================
+ Coverage   72.11%   72.13%   +0.02%     
==========================================
  Files         120      120              
  Lines        9814     9815       +1     
==========================================
+ Hits         7077     7080       +3     
+ Misses       2015     2014       -1     
+ Partials      722      721       -1     
Impacted Files Coverage Δ
pkg/v1/tarball/layer.go 66.83% <0.00%> (-0.35%) ⬇️
pkg/crane/optimize.go 74.69% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh enabled auto-merge (squash) April 19, 2023 14:48
@imjasonh imjasonh merged commit 217318c into google:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants