stop estargz-optimizing #1015
Closed
stop estargz-optimizing #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 52.80% 52.80%
=======================================
Files 43 43
Lines 3348 3348
=======================================
Hits 1768 1768
Misses 1355 1355
Partials 225 225
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This Pull Request is stale because it has been open for 90 days with |
evankanderson
approved these changes
Jul 19, 2023
|
@imjasonh maybe a rebase here :) |
|
Fixed in #1142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't do anything unless
GGCR_EXPERIMENTAL_ESTARGZwas also set, but if it was it would tell estargz to prioritize fetching the app binary.In light of google/go-containerregistry#1660 we don't want to use this deprecated method.