-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support - Fix tests, enable CI, and release Windows binaries #780
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 75.54% 75.60% +0.05%
==========================================
Files 102 102
Lines 4171 4185 +14
==========================================
+ Hits 3151 3164 +13
Misses 566 566
- Partials 454 455 +1
Continue to review full report at Codecov.
|
@jonjohnsonjr Are there any questions I can answer or anything you need from me on this PR? |
Not yet! I'm currently in the process of moving, so my life is a bit hectic at the moment. Hopefully I'll be able to give this a proper review by the end of the week (no promises!). Apologies for the delay, I really appreciate your contribution here. |
No worries. I know how all-consuming moving can be. Hope all goes well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test file cannot run if Docker is in Windows container mode because crane can only pull Linux containers.
Let's try that again when #742 lands.
1db5480
to
ce63f98
Compare
@jonjohnsonjr Ok, I made the requested changes and rebased to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this!
@jonjohnsonjr Would it be possible to publish a release that contains these changes? |
Certainly! I'm juggling a few things but I want to test #851 against travis and get it merged before I cut a new release. Hopefully I can get to it by the end of today (and if you see anything glaringly wrong about that PR, please let me know). |
@jonjohnsonjr Awesome! Thanks for the new release! 😃 |
Fixes #778
With these changes, all tests pass running on a Windows system with Docker in Linux container mode.
One test file cannot run if Docker is in Windows container mode because crane can only pull Linux containers.
I'm not normally a Go developer, so let me know if I need to make any changes to how I've done anything here.
Please take a hard look at the "unclosed ReadClosers" fix, as that one is the most involved and has the most potential for me to have done something incorrectly.