Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support - Fix tests, enable CI, and release Windows binaries #780

Merged
merged 7 commits into from
Oct 27, 2020

Conversation

mterrel
Copy link
Contributor

@mterrel mterrel commented Oct 7, 2020

Fixes #778

With these changes, all tests pass running on a Windows system with Docker in Linux container mode.
One test file cannot run if Docker is in Windows container mode because crane can only pull Linux containers.

I'm not normally a Go developer, so let me know if I need to make any changes to how I've done anything here.

Please take a hard look at the "unclosed ReadClosers" fix, as that one is the most involved and has the most potential for me to have done something incorrectly.

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mterrel
Copy link
Contributor Author

mterrel commented Oct 7, 2020

@googlebot I signed it!

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #780 into master will increase coverage by 0.05%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   75.54%   75.60%   +0.05%     
==========================================
  Files         102      102              
  Lines        4171     4185      +14     
==========================================
+ Hits         3151     3164      +13     
  Misses        566      566              
- Partials      454      455       +1     
Impacted Files Coverage Δ
pkg/v1/cache/fs.go 70.00% <88.88%> (+1.48%) ⬆️
pkg/v1/mutate/mutate.go 71.97% <100.00%> (+0.36%) ⬆️
pkg/v1/tarball/image.go 77.77% <100.00%> (+0.75%) ⬆️
pkg/v1/tarball/layer.go 73.33% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f0bba...ce63f98. Read the comment docs.

@mterrel
Copy link
Contributor Author

mterrel commented Oct 14, 2020

@jonjohnsonjr Are there any questions I can answer or anything you need from me on this PR?

@jonjohnsonjr
Copy link
Collaborator

any questions I can answer or anything you need from me on this PR?

Not yet! I'm currently in the process of moving, so my life is a bit hectic at the moment. Hopefully I'll be able to give this a proper review by the end of the week (no promises!).

Apologies for the delay, I really appreciate your contribution here.

@mterrel
Copy link
Contributor Author

mterrel commented Oct 14, 2020

any questions I can answer or anything you need from me on this PR?

Not yet! I'm currently in the process of moving, so my life is a bit hectic at the moment. Hopefully I'll be able to give this a proper review by the end of the week (no promises!).

Apologies for the delay, I really appreciate your contribution here.

No worries. I know how all-consuming moving can be. Hope all goes well!

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test file cannot run if Docker is in Windows container mode because crane can only pull Linux containers.

Let's try that again when #742 lands.

pkg/v1/mutate/mutate.go Outdated Show resolved Hide resolved
@mterrel
Copy link
Contributor Author

mterrel commented Oct 22, 2020

@jonjohnsonjr Ok, I made the requested changes and rebased to master.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@jonjohnsonjr jonjohnsonjr merged commit 0d898ee into google:master Oct 27, 2020
@mterrel
Copy link
Contributor Author

mterrel commented Nov 30, 2020

@jonjohnsonjr Would it be possible to publish a release that contains these changes?

@jonjohnsonjr
Copy link
Collaborator

Certainly! I'm juggling a few things but I want to test #851 against travis and get it merged before I cut a new release. Hopefully I can get to it by the end of today (and if you see anything glaringly wrong about that PR, please let me know).

@mterrel
Copy link
Contributor Author

mterrel commented Dec 1, 2020

@jonjohnsonjr Awesome! Thanks for the new release! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release builds for Windows
3 participants