-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arm and arm64 #851
Conversation
Seems to work?
|
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
=======================================
Coverage 74.67% 74.67%
=======================================
Files 106 106
Lines 4435 4435
=======================================
Hits 3312 3312
Misses 633 633
Partials 490 490 Continue to review full report at Codecov.
|
Something isn't right with how we re-exec ourselves to fake gcloud, so disable that for arm.
This is causing travis to be really slow on my machine.
The google auth tests are broken on arm for some reason, so I've disabled them with I pruned the matrix down to just use go1.15 and @imjasonh added a test for
That is still actually really slow... I'm surprised by it, but looking at the test it makes some sense: idx[0] = 2 images I'm still a bit surprised that we'd spend 38 seconds in that. In theory we'd calculate the digest just once for each layer. It looks like we don't memoize the digest for |
So far everything but windows has passed so this looks pretty good. |
🎉 |
Fixes #850