-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add:registry ping timeout #808
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 103 103
Lines 4309 4309
=======================================
Hits 3228 3228
Misses 605 605
Partials 476 476
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with this being hardcoded to 2s for now, but that might be too low for people on really unreliable/slow internet. If we see that happening, I may make this configurable or just increase the timeout.
Thanks! |
Of course, 2s is indeed a bit short, because I just changed it briefly and temporarily. I hope you can change the specific configuration. |
I see that registry ping does not have timeout handling. The makeFetcher function clearly has a ctx timeout handling. Why is it not set during ping? I currently set the easiest 3 second timeout.