Plumb contexts through transport.New #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @CodingJzy this will revert #808 and use the context from |
Add transport.NewWithContext. Use the provided context for the initial ping request and token exchange. Subsequent token exchanges (to refresh) will use the context of the incoming request in RoundTrip. Drop the hardcoded ping timeout. Use transport.NewWithContext everywhere that's easily plumbable.
jonjohnsonjr
force-pushed
the
timeout
branch
from
b490ab1
to
0ee3936
Compare
thank you，Your way of passing in the context parameter is correct. I just discovered the problem, and then temporarily added a 2s timeout, which did not fundamentally solve the problem. |
imjasonh
approved these changes
Nov 18, 2020
|
Thanks for making us aware of the problem @CodingJzy 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #832
Add transport.NewWithContext.
Use the provided context for the initial ping request and token
exchange.
Subsequent token exchanges (to refresh) will use the context of the
incoming request in RoundTrip.
Drop the hardcoded ping timeout.
Use transport.NewWithContext everywhere that's easily plumbable.