Implement better user agent support #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 74.50% 74.60% +0.09%
==========================================
Files 106 105 -1
Lines 4429 4406 -23
==========================================
- Hits 3300 3287 -13
+ Misses 638 633 -5
+ Partials 491 486 -5
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Nov 21, 2020
|
Rebased onto #845 Changes from just this PR: https://github.com/google/go-containerregistry/pull/837/files/100d667650035d53e68bde780fef99e25b5da7f8..0877d987d3bc4be5f709db8e23a2c2c2b157ec14 |
This allows you to supply a customer user agent string that will be
prepended before the go-containerregistry portion.
This uses go module build info to determine the version of
go-containerregistry that you have pulled in, which will be included in
the user agent as "go-containerregistry/${VERSION}". If we cannot get
the version, this is just "go-containerregistry".
|
Presumably, this won't break windows, and I don't want to wait in the queue for another hour 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #830