Refactor [g]crane to make threading options easier #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split out some of this from #837
This addresses a few things:
gcrane
now inherits the options/flags fromcrane
(e.g.--insecure
,--platform
,-v
, theheaderTransport
thing). Some of these were duplicated code, others were just broken ingcrane
.init
for the cmd packagesgcrane.Keychain
through as the default keychain for gcrane (Fixes Use Google keychain on gcrane commands #721).I ended up passing a pointer to a slice of options through the command init logic, which feels kind of gross, but a lot less gross than having package-level globals... let me know if you have a better suggestion. I think we need to do this because
PersistentPreRun
has to modify the options, but we've already created each command by the time that runs... :/