-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put k8schain in its own go module #904
Conversation
096eb32
to
fe62ad5
Compare
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 72.60% 72.57% -0.04%
==========================================
Files 108 108
Lines 4687 4689 +2
==========================================
Hits 3403 3403
- Misses 774 776 +2
Partials 510 510
Continue to review full report at Codecov.
|
Per https://pkg.go.dev/github.com/google/go-containerregistry/pkg/authn/k8schain?tab=importedby y'all might be affected. cc @andreyvelich |
Split this up into two commits:
I didn't vendor the k8schain deps because I think it might break some expectations of various tools (only one top-level vendor/ directory). That's why there's the huge negative diff. Hopefully that's fine. |
Did you add any presubmit safeguard that the nested module files are correct? |
cc @tejal29 as well |
Done: 52dc010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonjohnsonjr! I'll test this out with our @crossplane usage 👍
Thank you for the notice @jonjohnsonjr! |
pkg/authn/k8schain/go.mod
Outdated
@@ -0,0 +1,23 @@ | |||
module github.com/google/go-containerregistry/pkg/authn/k8schain | |||
|
|||
go 1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the parent is 1.14, these should be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine for them to diverge in the future, but I've dropped this to 1.14.
This should make go-containerregistry much easier to use.
#902
ko-build/ko#287
ko-build/ko#258 (comment)
WANT_LGTM=all