Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate installing ko from ./cmd/ko #258

Closed
n3wscott opened this issue Dec 4, 2020 · 6 comments
Closed

Deprecate installing ko from ./cmd/ko #258

n3wscott opened this issue Dec 4, 2020 · 6 comments

Comments

@n3wscott
Copy link
Contributor

n3wscott commented Dec 4, 2020

As one of ko's biggest fans, it pains me to see people fail to install ko by trying:

go install github.com/google/ko

Because this repo is not likely to have more than one executable, let's move the binary to the root to make the logical install line above work as expected.

@antoineco
Copy link
Contributor

antoineco commented Jan 7, 2021

I think this can be closed now that is #257 in on master?

@imjasonh
Copy link
Member

imjasonh commented Jan 7, 2021

Can we also instead recommend installing from released binaries, instead of using go install?

Some user reports indicate this approach might lead to friction, since users should run the command outside of a directory that's part of a Go module, and might be broken by case-sensitivity bugs if some packages had previously been fetched on the user's machine.

Installing from prebuilt released binaries should be the default.

@jonjohnsonjr
Copy link
Collaborator

Some user reports indicate this approach might lead to friction, since users should run the command outside of a directory that's part of a Go module, and might be broken by case-sensitivity bugs if some packages had previously been fetched on the user's machine.

I think this is why @n3wscott filed #288

Installing with go is broken such that you don't pick up the latest release, AFAICT.

@n3wscott
Copy link
Contributor Author

n3wscott commented Jan 7, 2021

Is there no issue to install the cmd version? I thought the casing issue is not related to where the exe is but a bad actor on the other lib

@jonjohnsonjr
Copy link
Collaborator

Jason's comment is unrelated to ./ko vs ./ko/cmd/ko AFAICT. Our releases are fine, but you can't install the latest release via go anymore, for some reason. I'm not sure how to fix this.

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants