Move ko binary to root of project. #257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 37.06% 37.06%
=======================================
Files 33 33
Lines 1465 1465
=======================================
Hits 543 543
Misses 833 833
Partials 89 89 Continue to review full report at Codecov.
|
|
|
||
| ```shell | ||
| GO111MODULE=on go get github.com/google/ko/cmd/ko | ||
| go get github.com/google/ko |
There was a problem hiding this comment.
What should we do for users that install from cmd/ko today in scripts? This change would break them without a lot of help about what changed or how to fix it.
Can we keep cmd/ko/main.go as an alias for a release or two with a deprecation warning?
There was a problem hiding this comment.
That was always my plan to keep both. We have a lot of tooling that hardcodes installing ko from the ./cmd/ko path.
There was a problem hiding this comment.
This change would break them without a lot of help about what changed or how to fix it.
It never broke them, I left ./cmd/ko in the PR.
There was a problem hiding this comment.
I did drop ./cmd/ko/test
hack/update-deps.sh
Outdated
|
|
||
| # HACK HACK HACK: | ||
| # Until we can cleanly remove it, copy root main.go and move it to ./cmd/ko | ||
| cp ${PROJECT_ROOT}/main.go ${PROJECT_ROOT}/cmd/ko/ |
There was a problem hiding this comment.
Is it possible to just commit a symlink to the root? Or would that break everything?
There was a problem hiding this comment.
Missed this 😇
I'd prefer something explicit since it also gives us an opportunity to inject a deprecation warning
There was a problem hiding this comment.
Added a message, dropped the copy,
| @@ -13,10 +13,10 @@ | |||
|
|
|||
| `ko` can be installed and upgraded by running: | |||
|
|
|||
| **Note**: Golang version `1.12.0` or higher is required. | |||
| **Note**: Golang version `1.14.0` or higher is required. | |||
There was a problem hiding this comment.
That is what the go mod file says.
It has become clear
koand this repo is a single tool repo. Let's embrace that, and allowgo get github.com/google/koto work as 99% of folks try to do without reading the readme.