Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return TotalCount in ListRepos in AppsService #1791

Closed
victor88121 opened this issue Feb 3, 2021 · 3 comments · Fixed by #1794
Closed

Return TotalCount in ListRepos in AppsService #1791

victor88121 opened this issue Feb 3, 2021 · 3 comments · Fixed by #1794
Assignees
@DarthBenro008
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). enhancement good first issue

Comments

@victor88121
Copy link

ListRepos currently only returns the list of repositories from github's response but not the total_count (Link). This total_count is different from just the length of the list of repositories returned if the number of repositories in the installation is greater than the per_page pagination limit set in the request. Is it possible to add it for ListRepos to return?
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 3, 2021

Ah, yes, I see that it was originally written this way in #436 and I unfortunately didn't catch it at the time.

Yes, I think we can easily add the field by making a new return struct, which would be a breaking API change.
I'll open this issue up to volunteers. Thanks, @victor88121.

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

@gmlewis gmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). enhancement good first issue labels Feb 3, 2021
@DarthBenro008
Copy link
Contributor

Hey @gmlewis,
I would like to work on this issue, could you please assign me this issue, if that's alright?

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 3, 2021

Thank you, @DarthBenro008 ! It's yours.

DarthBenro008 added a commit to DarthBenro008/go-github that referenced this issue Feb 4, 2021
@DarthBenro008
feat: google#1791 new ListRepositories struct and tests
70ace69
@DarthBenro008 DarthBenro008 mentioned this issue Feb 4, 2021
Merged
gmlewis pushed a commit that referenced this issue Feb 4, 2021
@DarthBenro008
Change ListRepos and ListUserRepos to return new ListRepositories str…
24b281b 
…uct with count (#1794)

Fixes: #1791 .
Note that this is a breaking API change slated for `v34`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarthBenro008 DarthBenro008

Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). enhancement good first issue
Projects
None yet
Milestone
No milestone
3 participants
@gmlewis @victor88121 @DarthBenro008