Change ListRepos and ListUserRepos to return new ListRepositories struct with count #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
==========================================
- Coverage 97.54% 97.54% -0.01%
==========================================
Files 98 98
Lines 6385 6383 -2
==========================================
- Hits 6228 6226 -2
Misses 85 85
Partials 72 72
Continue to review full report at Codecov.
|
gmlewis
requested changes
Feb 4, 2021
There was a problem hiding this comment.
Thank you, @DarthBenro008 !
Just one minor comment addition, please, then we should be ready for a second LGTM before merging.
gmlewis
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Thank you, @DarthBenro008 !
LGTM.
Awaiting second LGTM before merging.
gmlewis
added
the
Breaking API Change
gmlewis
changed the title
|
Thank you, @wesleimp ! |
Erouan50
added a commit
to Erouan50/terraform-provider-github
that referenced
this pull request
Apr 27, 2021
go-github released the Go client library to [35.1.0][1] 3 days ago. The 33, 34, 35 versions don't bring a lot of breaking changes that would impact the provider. Only the [change][2] on ListRepo and ListUserRepos from release 34 seems to have an impact. To give some more context, I need this version to enhance the `github-ip-ranges` by adding the missing [IP ranges][3] (actions, web, etc...) I didn't run the full ACC tests so if someone can run them for me and communicate me any failing, I'll be more than happy to fix them. Fix integrations#766 [1]: https://github.com/google/go-github/releases/tag/v35.1.0 [2]: google/go-github#1794 [3]: https://docs.github.com/en/rest/reference/meta
jcudit
pushed a commit
to integrations/terraform-provider-github
that referenced
this pull request
May 11, 2021
* Update go-github to 35.1.0 go-github released the Go client library to [35.1.0][1] 3 days ago. The 33, 34, 35 versions don't bring a lot of breaking changes that would impact the provider. Only the [change][2] on ListRepo and ListUserRepos from release 34 seems to have an impact. To give some more context, I need this version to enhance the `github-ip-ranges` by adding the missing [IP ranges][3] (actions, web, etc...) I didn't run the full ACC tests so if someone can run them for me and communicate me any failing, I'll be more than happy to fix them. Fix #766 [1]: https://github.com/google/go-github/releases/tag/v35.1.0 [2]: google/go-github#1794 [3]: https://docs.github.com/en/rest/reference/meta * Fix Go file formats Co-authored-by: Jeremy Udit <jcudit@github.com>
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* Update go-github to 35.1.0 go-github released the Go client library to [35.1.0][1] 3 days ago. The 33, 34, 35 versions don't bring a lot of breaking changes that would impact the provider. Only the [change][2] on ListRepo and ListUserRepos from release 34 seems to have an impact. To give some more context, I need this version to enhance the `github-ip-ranges` by adding the missing [IP ranges][3] (actions, web, etc...) I didn't run the full ACC tests so if someone can run them for me and communicate me any failing, I'll be more than happy to fix them. Fix integrations#766 [1]: https://github.com/google/go-github/releases/tag/v35.1.0 [2]: google/go-github#1794 [3]: https://docs.github.com/en/rest/reference/meta * Fix Go file formats Co-authored-by: Jeremy Udit <jcudit@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apps_installations_test.go