Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add ListRunnersOptions to support all query parameters #3094

Merged
merged 2 commits into from
May 1, 2024

Conversation

fentas
Copy link
Contributor

@fentas fentas commented Mar 5, 2024

Fixes: #3093.

BREAKING-CHANGE: This changes ListOptions to ListRunnersOptions in ListRunners and ListOrganizationRunners.

Let me know if something is missing 🙌

Edit: I agreed to the CLA.

Copy link

google-cla bot commented Mar 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Mar 5, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fentas !
One tweak, please, then you will need to update your tests and run step 4 scripts listed in CONTRIBUTING.md.

Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

I'll also change the PR title to note that this is a breaking API change.

github/actions_runners.go Outdated Show resolved Hide resolved
@gmlewis gmlewis changed the title Add ListRunnersOptions to support all query parameters feat!: Add ListRunnersOptions to support all query parameters Mar 5, 2024
@fentas fentas force-pushed the ListRunnersOptions branch from 8c8f016 to 765fbf8 Compare March 5, 2024 12:04
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2b8c7fa) to head (843b6c4).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   97.72%   92.87%   -4.86%     
==========================================
  Files         153      170      +17     
  Lines       13390    11403    -1987     
==========================================
- Hits        13085    10590    -2495     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 5, 2024

Just for future reference, you never need to force push to PRs in this repo (and we prefer if you don't to make reviews easier to see what changed) because we always squash and merge here. Thanks.
Obviously, no big deal in this case. 😁

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fentas !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@be0x74a be0x74a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@gmlewis
Copy link
Collaborator

gmlewis commented May 1, 2024

Thank you, @be0x74a !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 1, 2024
@gmlewis gmlewis merged commit faffd29 into google:master May 1, 2024
6 of 7 checks passed
ponkio-o added a commit to ponkio-o/go-github that referenced this pull request May 13, 2024
@fentas fentas deleted the ListRunnersOptions branch May 13, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List[Organization]Runners does not support all query parameters
3 participants