-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Change enterprise runner to also use ListRunnersOptions #3167
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3167 +/- ##
==========================================
- Coverage 97.72% 92.91% -4.81%
==========================================
Files 153 171 +18
Lines 13390 11502 -1888
==========================================
- Hits 13085 10687 -2398
- Misses 215 724 +509
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
@gmlewis Sorry, I just completed signing the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ponkio-o !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@fentas - perhaps you are available to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you, @fentas ! Merging. |
Fixes: #3166.
BREAKING-CHANGE: This changes
ListOptions
toListRunnersOptions
inEnterpriseService.ListRunners
.I fixed a bug related ListRunners API. The
ListRunnersOptions
was not being applied to Enterprise Runner.follow up: #3094