Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Change default tpm path to use correct defaults #123

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Jun 29, 2021

This makes sure gotpm does the right thing on systems that don't
support the RM.

Signed-off-by: Joe Richey joerichey@google.com

Copy link
Contributor

@jkl73 jkl73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why can't we have the default tpmpath logic here (instead of go-tpm)? I feel like that's a somewhat very specific use case in the cmd tool.

Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Copy link
Member Author

LGTM, but why can't we have the default tpmpath logic here (instead of go-tpm)? I feel like that's a somewhat very specific use case in the cmd tool.

This is a good point. I updated the PR to not depend on google/go-tpm#256. Instead it just implements the logic in this package. This should make things easier, and it still solves the problem.

I also updated our dependencies and ran go mod tidy.

@josephlr josephlr merged commit dc306dc into google:master Jun 29, 2021
@josephlr josephlr deleted the gotpm branch June 29, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants