tpm2: Allow for tpm2.OpenTPM() to use default paths on Linux #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmwu
reviewed
Jul 1, 2021
tpm2/open_other.go
Outdated
| switch len(path) { | ||
| case 0: | ||
| tpm, err = tpmutil.OpenTPM("/dev/tpmrm0") | ||
| if os.IsNotExist(err) { |
There was a problem hiding this comment.
we should use errors.Is(err, os.ErrNotExist) https://golang.org/src/os/error.go?s=3221:3252#L82
alexmwu
approved these changes
Jul 1, 2021
brandonweeks
approved these changes
Jul 1, 2021
|
This PR is technically a breaking change, if anyone depends on the signature of OpenTPM on non Windows GOOSes. See https://blog.golang.org/module-compatibility#TOC_2. We may want to update the minor version. |
This is a _breaking_ change. Signed-off-by: Joe Richey <joerichey@google.com>
|
Discussed offline w/ Alex and Maintainers, we will have a minor breaking release of go-tpm to include this and other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to easily to "the right thing" on Linux, which is to try to open
/dev/tpmrm0and then fall back to/dev/tpm0if the RM doesn't exist. This is what tpm2-tss does.Signed-off-by: Joe Richey joerichey@google.com