Fix panic catching in launcher and AKCert #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkl73
force-pushed
the
fixakcertanddefer
branch
2 times, most recently
from
b25a1ca to
7e32a8c
Compare
alexmwu
reviewed
Nov 22, 2022
launcher/launcher/main.go
Outdated
|
|
||
| logger = log.Default() | ||
| // default logger output to stderr |
There was a problem hiding this comment.
log.Default() will print to stderr, I want it to output to stdout. I will make the comment more clear.
There was a problem hiding this comment.
any reason we want stdout instead
There was a problem hiding this comment.
no particular, most of the log we output info, so stdout seems like a better fit.
jkl73
force-pushed
the
fixakcertanddefer
branch
2 times, most recently
from
75682f8 to
d6b0c54
Compare
alexmwu
reviewed
Nov 22, 2022
launcher/launcher/main.go
Outdated
|
|
||
| logger = log.Default() | ||
| // default logger output to stderr |
There was a problem hiding this comment.
any reason we want stdout instead
alexmwu
approved these changes
Nov 22, 2022
jkl73
force-pushed
the
fixakcertanddefer
branch
from
d6b0c54 to
73277c8
Compare
Catch panic using defer recovery in launcher. Return an empty MachineState pointer instead of nil in validateAKCert. Signed-off-by: Jiankun Lu <jiankun@google.com>
jkl73
force-pushed
the
fixakcertanddefer
branch
from
73277c8 to
646e9b1
Compare
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Dec 16, 2022
Breaking Changes: New Features: Add IsHardened in launch spec: google#244 Add container logging redirect policy: google#249 Add SEV-SNP attestation support: google#240 Integrity-protect stateful partition on CS image: google#251 Retry launcher OIDC token refresh with backoff: google#261 Change restart policy behavior to reboot: google#260 Add ability to GetGCEInstanceInfo from a certificate: google#267 Bug Fixes: COS event log: require CEL events to use PCR13, add a launch separator, and don't skip unknown events: google#246 Measure LaunchSeparator event: google#247 Skip unallocated PCR selections when reading all PCRs: google#258 Remove gRPC client and use of insecure credentials: google#262 Fix server.VerifyAttestation proto merging(google#263) and defer of os.Exit(google#264): google#265 Other Changes: Add fake verifier client: google#234 Update CI Go Version to 1.19: google#241 Add launcher integration testing support: google#255 Test multi-writer PD creation disabled: google#256 Update go-sev-guest dependency to v0.2.6: google#259 Change OIDC retry policy to hourly and add jitter to refresh time: google#266 Add wrapper cloudbuild workflow to trigger image build and testing: google#269
Merged
alexmwu
added a commit
that referenced
this pull request
Dec 16, 2022
Breaking Changes: New Features: Add IsHardened in launch spec: #244 Add container logging redirect policy: #249 Add SEV-SNP attestation support: #240 Integrity-protect stateful partition on CS image: #251 Retry launcher OIDC token refresh with backoff: #261 Change restart policy behavior to reboot: #260 Add ability to GetGCEInstanceInfo from a certificate: #267 Bug Fixes: COS event log: require CEL events to use PCR13, add a launch separator, and don't skip unknown events: #246 Measure LaunchSeparator event: #247 Skip unallocated PCR selections when reading all PCRs: #258 Remove gRPC client and use of insecure credentials: #262 Fix server.VerifyAttestation proto merging(#263) and defer of os.Exit(#264): #265 Other Changes: Add fake verifier client: #234 Update CI Go Version to 1.19: #241 Add launcher integration testing support: #255 Test multi-writer PD creation disabled: #256 Update go-sev-guest dependency to v0.2.6: #259 Change OIDC retry policy to hourly and add jitter to refresh time: #266 Add wrapper cloudbuild workflow to trigger image build and testing: #269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #264 and #263
Catch panic using defer recovery in launcher.
Return an empty MachineState pointer instead of nil in validateAKCert.
Signed-off-by: Jiankun Lu jiankun@google.com