Update cloudbuild workflow for launcher #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
launcher/image/cloudbuild.yaml
Outdated
| '_BASE_IMAGE': '' | ||
| '_BASE_IMAGE_PROJECT': 'cos-cloud' | ||
| '_OUTPUT_IMAGE_SUFFIX': '' | ||
| '_IMAGE_ENV': 'debug' |
There was a problem hiding this comment.
Thoughts on changing this to "_IS_DEBUG" (boolean) and doing away with the concept of "hardened" (like how we have for our stable releases)?
There was a problem hiding this comment.
I think it is better to be explicit about the value here, because it will be passed around different cloudbuild/scripts
alexmwu
reviewed
Dec 7, 2022
There was a problem hiding this comment.
In general, I don't see many issues here. However, I think we should use Github Actions to replace the top-level cloudbuild script (the new cloudbuild.yaml). This has the advantages of
- not having to worry about timing out the top-level cloudbuild
- not being written in Bash/it's declarative
- don't have to /gcbrun
- can set https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request with author_association so it only autotriggers with maintainers/collaborators
- can use workflow_dispatch to trigger for outside PRs: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
Fix TextRefreshToken test. Create a overall cloudbuild file can trigger image building and testing cloudbuild workflow. Signed-off-by: Jiankun Lu <jiankun@google.com>
alexmwu
approved these changes
Dec 13, 2022
alexmwu
added a commit
to alexmwu/go-tpm-tools
that referenced
this pull request
Dec 16, 2022
Breaking Changes: New Features: Add IsHardened in launch spec: google#244 Add container logging redirect policy: google#249 Add SEV-SNP attestation support: google#240 Integrity-protect stateful partition on CS image: google#251 Retry launcher OIDC token refresh with backoff: google#261 Change restart policy behavior to reboot: google#260 Add ability to GetGCEInstanceInfo from a certificate: google#267 Bug Fixes: COS event log: require CEL events to use PCR13, add a launch separator, and don't skip unknown events: google#246 Measure LaunchSeparator event: google#247 Skip unallocated PCR selections when reading all PCRs: google#258 Remove gRPC client and use of insecure credentials: google#262 Fix server.VerifyAttestation proto merging(google#263) and defer of os.Exit(google#264): google#265 Other Changes: Add fake verifier client: google#234 Update CI Go Version to 1.19: google#241 Add launcher integration testing support: google#255 Test multi-writer PD creation disabled: google#256 Update go-sev-guest dependency to v0.2.6: google#259 Change OIDC retry policy to hourly and add jitter to refresh time: google#266 Add wrapper cloudbuild workflow to trigger image build and testing: google#269
Merged
alexmwu
added a commit
that referenced
this pull request
Dec 16, 2022
Breaking Changes: New Features: Add IsHardened in launch spec: #244 Add container logging redirect policy: #249 Add SEV-SNP attestation support: #240 Integrity-protect stateful partition on CS image: #251 Retry launcher OIDC token refresh with backoff: #261 Change restart policy behavior to reboot: #260 Add ability to GetGCEInstanceInfo from a certificate: #267 Bug Fixes: COS event log: require CEL events to use PCR13, add a launch separator, and don't skip unknown events: #246 Measure LaunchSeparator event: #247 Skip unallocated PCR selections when reading all PCRs: #258 Remove gRPC client and use of insecure credentials: #262 Fix server.VerifyAttestation proto merging(#263) and defer of os.Exit(#264): #265 Other Changes: Add fake verifier client: #234 Update CI Go Version to 1.19: #241 Add launcher integration testing support: #255 Test multi-writer PD creation disabled: #256 Update go-sev-guest dependency to v0.2.6: #259 Change OIDC retry policy to hourly and add jitter to refresh time: #266 Add wrapper cloudbuild workflow to trigger image build and testing: #269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an overall cloudbuild file that can trigger multiple image building and testing cloudbuild workflows.
Reduce the cloudbuild trigger to one, now the only cloudbuild workload can build both hardened and debug images, and run tests on those images.
The image building workload will now auto pick the latest cos dev image to build (if no overrides).
Also, now the cloudbuild needs to be triggered manually by commenting "/gcbrun" in a PR.Fixing a condition in TestRefreshToken.
Signed-off-by: Jiankun Lu jiankun@google.com