Fix Mingw-w64 build #856
Fix Mingw-w64 build #856
Conversation
| if ($env:generator -eq "MinGW Makefiles") { | ||
| $env:path = $env:path.replace("C:\Program Files\Git\usr\bin;", "") | ||
| if ($env:compiler -eq "gcc-5.3.0-posix") { | ||
| $cxx_path = "C:\mingw-w64\i686-5.3.0-posix-dwarf-rt_v4-rev0\mingw32\bin" |
There was a problem hiding this comment.
Why are we being so specific here and specifying a path off of C:\ ?
Sorry I don't understand why so many files are being rewritten here.
There was a problem hiding this comment.
Why are we being so specific here?
For "MinGW Makefiles" CMake generator we remove Git from PATH environment variable and add mingw-w64 to PATH, so CMake able to build gtest.
... and specifying a path off of C:\
AppVeyor has preinstalled mingw-w64 i686-5.3.0 to this PATH https://www.appveyor.com/docs/installed-software/#mingw-msys-cygwin
KindDragon
force-pushed
the
mingw-appveyor
branch
from
bc9c69b to
b2df26b
Compare
KindDragon
force-pushed
the
mingw-appveyor
branch
2 times, most recently
from
dc19770 to
b7c6562
Compare
KindDragon
changed the title
KindDragon
changed the title
KindDragon
force-pushed
the
mingw-appveyor
branch
from
b7c6562 to
e9f9147
Compare
|
Now it should works with all cases |
|
This patch works for me with MinGW 4.8.2. I'm not exercising the AppVeyor part of of it though. |
| @@ -396,7 +396,7 @@ | |||
| # include <io.h> | |||
| # endif | |||
| // In order to avoid having to include <windows.h>, use forward declaration | |||
| #if GTEST_OS_WINDOWS_MINGW | |||
| #if GTEST_OS_WINDOWS_MINGW && !defined(__MINGW64_VERSION_MAJOR) | |||
There was a problem hiding this comment.
I can confirm that MinGW 4.8.2 g++ does not define this symbol.
The only symbols defined by that compiler with "MINGW" in its name are:
__MINGW32__for the 32 bit compiler.- both
__MINGW32__and__MINGW64__for the 64 bit compiler
|
This PR fixes google-test building for me. Today's (commit Windows 10 I'm looking forward to this PR merge 👍 |
|
Hi @BillyDonahue please take another look at this. |
|
Is this the old mingw/msys or the new msys2/mingw64 from https://github.com/Alexpux/MINGW-packages? |
KindDragon
force-pushed
the
mingw-appveyor
branch
from
e9f9147 to
d8fe70f
Compare
|
@rakhimov I'm using g++-mingw-w64 4.8.2-10ubuntu2+12 from Ubuntu trusty. As far as I know it's the stock mingw for Ubuntu trusty. |
Update Google Test library to a version that contains a fix for building under MinGW. This issue seems to have been resolved in pull request google/googletest#856
Update Google Test library to a version that contains a fix for building under MinGW. This issue seems to have been resolved in pull request google/googletest#856
When compiling with MinGW, we no longer need to use -Dgtest_disable_pthreads=ON. See google/googletest#856 and google/googletest#721
When compiling with MinGW, we no longer need to use -Dgtest_disable_pthreads=ON. See google/googletest#856 and google/googletest#721
When compiling with MinGW, we no longer need to use -Dgtest_disable_pthreads=ON. See google/googletest#856 and google/googletest#721
@BillyDonahue PR #721 break build with Mingw-w64, this PR should fix this