Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fixed for mingw 5.3 #866

Closed
wants to merge 3 commits into from
Closed

Conversation

evgen48
Copy link

@evgen48 evgen48 commented Sep 1, 2016

fixed pointers casting GTEST_CRITICAL_SECTION* to CRITICAL_SECTION* and vice versa introduced in pull request #721

Signed-off-by: Eugene Smirnov o1o2o3o4o5@gmail.com

… to CRITICAL_SECTION* and vice versa

Signed-off-by: Eugene Smirnov <o1o2o3o4o5@gmail.com>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@evgen48
Copy link
Author

evgen48 commented Sep 1, 2016

I signed CLA!

@googlebot
Copy link

CLAs look good, thanks!

Signed-off-by: Eugene Smirnov <o1o2o3o4o5@gmail.com>
@KindDragon
Copy link
Contributor

Hi. This already fixed in PRs #856 and #811

@evgen48
Copy link
Author

evgen48 commented Sep 2, 2016

Thanks, @KindDragon, I didn't find #811 patch that actually fixed problems in build. Once it is integrated #856 can pass the appveyor build - right?
Should I close this pull request safely then?

@KindDragon
Copy link
Contributor

Once it is integrated #856 can pass the appveyor build - right?

Yes you are right.

Should I close this pull request safely then?

Yeap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants