Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error prone warns #2320

Merged
merged 57 commits into from
Mar 1, 2023
Merged

Commits on Feb 18, 2023

  1. Configuration menu
    Copy the full SHA
    18336d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c2f8c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f64bf3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f34c35d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5e6a279 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    682b369 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    41e0c28 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b6965d1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    04feff6 View commit details
    Browse the repository at this point in the history
  10. Removes an unused import

    MaicolAntali committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    5bd180d View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Configuration menu
    Copy the full SHA
    373525d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd60abf View commit details
    Browse the repository at this point in the history
  3. Remove unused imports

    Removed from:
    - ParseBenchmark
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    5e1e970 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f3c4763 View commit details
    Browse the repository at this point in the history
  5. Excludes from proto just the generated code.

    Replaces `.*proto.*` with `.*/generated-test-sources/protobuf/.*` in such way will be excluded just the generated code and not the whole `proto` directory
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    71a75b8 View commit details
    Browse the repository at this point in the history
  6. Removes an unused variable

    Removes the `descriptor` variable because is unused.
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    a1beaf2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9c5073f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2aad0bc View commit details
    Browse the repository at this point in the history
  9. Enables ErrorProne in gson/src/test.*

    Removes the `gson/src/test.*` path from the `-XepExcludedPaths` parameter of the ErrorProne plugin
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    ba27715 View commit details
    Browse the repository at this point in the history
  10. Fixes UnusedVariable warns

    This commit fix all `UnusedVariable` warns given by ErrorProne in the `gson/src/test.*` path.
    
    Some field is annotated with `@Keep` that means is used by reflection.
    In some other case the record is annotated with `@SuppressWarnings("unused")`
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    e3d65bc View commit details
    Browse the repository at this point in the history
  11. Fixes JavaUtilDate warns

    This commit fix all `JavaUtilDate` warns given by ErrorProne in the `gson/src/test.*` path.
    
    Classes/Methods are annotated with `@SuppressWarnings("JavaUtilDate")` because it's not possible use differente Date API.
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    d1c0554 View commit details
    Browse the repository at this point in the history
  12. Fixes EqualsGetClass warns

    This commit fix all `EqualsGetClass` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have rewrite the `equals()` methods to use `instanceof`
    MaicolAntali committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    7769c75 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a8cff33 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Fixes JdkObsolete warns

    This commit fix all `JdkObsolete` warns given by ErrorProne in the `gson/src/test.*` path.
    
    In some cases I have replaced the obsolete JDK classes with the newest alternatives.  In other cases, I have added the `@SuppressWarnings("JdkObsolete")`
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    eb05e0d View commit details
    Browse the repository at this point in the history
  2. Fixes ClassCanBeStatic warns

    This commit fix all `ClassCanBeStatic` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have added the `static` keyword, or I have added `@SuppressWarnings("ClassCanBeStatic")`
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ef27eb4 View commit details
    Browse the repository at this point in the history
  3. Fixes UndefinedEquals warns

    This commit fix all `UndefinedEquals` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have added `@SuppressWarnings("UndefinedEquals")` or fixed the asserts
    
    Note: In this commit I have also renamed a test from `testRawCollectionDeserializationNotAlllowed` to `testRawCollectionDeserializationNotAllowed`
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    69b34be View commit details
    Browse the repository at this point in the history
  4. Fixes GetClassOnEnum warns

    This commit fix all `GetClassOnEnum` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have replaced the `.getClass()` with `.getDeclaringClass()`
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7a20385 View commit details
    Browse the repository at this point in the history
  5. Fixes ImmutableEnumChecker warns

    This commit fix all `ImmutableEnumChecker` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have added the `final` keyword, or I have added the `@SuppressWarnings("ImmutableEnumChecker")` annotation
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4627307 View commit details
    Browse the repository at this point in the history
  6. Fixes StaticAssignmentOfThrowable warns

    This commit fix all `StaticAssignmentOfThrowable` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    13de98d View commit details
    Browse the repository at this point in the history
  7. Fixes AssertionFailureIgnored warns

    This commit fix all `AssertionFailureIgnored` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have added the `@SuppressWarnings("AssertionFailureIgnored")` annotation
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3ae4fac View commit details
    Browse the repository at this point in the history
  8. Fixes ModifiedButNotUsed warns

    This commit fix all `ModifiedButNotUsed` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have added the `@SuppressWarnings("ModifiedButNotUsed")` annotation
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    661eae8 View commit details
    Browse the repository at this point in the history
  9. Fixes MissingSummary warns

    This commit fix all `MissingSummary` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have remove the Javadoc `@author`
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2742881 View commit details
    Browse the repository at this point in the history
  10. Fixes FloatingPointLiteralPrecision warns

    This commit fix all `FloatingPointLiteralPrecision` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have added the `@SuppressWarnings("FloatingPointLiteralPrecision")` annotation
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7d688ed View commit details
    Browse the repository at this point in the history
  11. Fixes StringSplitter warns

    This commit fix all `StringSplitter` warns given by ErrorProne in the `gson/src/test.*` path.
    
    I have replaced the `String.split(...)` with `Splitter`
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    67a8edf View commit details
    Browse the repository at this point in the history
  12. Fixes EmptyCatch warns

    This commit fix all `EmptyCatch` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    b92cb96 View commit details
    Browse the repository at this point in the history
  13. Fixes UnicodeEscape warns

    This commit fix all `UnicodeEscape` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    dcb277e View commit details
    Browse the repository at this point in the history
  14. Fixes EmptyBlockTag warns

    This commit fix all `EmptyBlockTag` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    6dee398 View commit details
    Browse the repository at this point in the history
  15. Fixes LongFloatConversion warns

    This commit fix all `LongFloatConversion` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    682d5df View commit details
    Browse the repository at this point in the history
  16. Fixes LongDoubleConversion warns

    This commit fix all `LongDoubleConversion` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    c1681bf View commit details
    Browse the repository at this point in the history
  17. Fixes TruthAssertExpected warns

    This commit fix all `TruthAssertExpected` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    69dcd03 View commit details
    Browse the repository at this point in the history
  18. Fixes UnusedMethod warns

    This commit fix all `UnusedMethod` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    03e86d6 View commit details
    Browse the repository at this point in the history
  19. Fixes UnusedTypeParameter warns

    This commit fix all `UnusedTypeParameter` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1feefb4 View commit details
    Browse the repository at this point in the history
  20. Fixes CatchFail warns

    This commit fix all `CatchFail` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7ac4465 View commit details
    Browse the repository at this point in the history
  21. Fixes MathAbsoluteNegative warns

    This commit fix all `MathAbsoluteNegative` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    92972bf View commit details
    Browse the repository at this point in the history
  22. Fixes LoopOverCharArray warns

    This commit fix all `LoopOverCharArray` warns given by ErrorProne in the `gson/src/test.*` path.
    
    `toCharArray` allocates a new array, using `charAt` is more efficient
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2167d4c View commit details
    Browse the repository at this point in the history
  23. Fixes HidingField warns

    This commit fix all `HidingField` warns given by ErrorProne in the `gson/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    126b1b5 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    4aaefea View commit details
    Browse the repository at this point in the history
  25. Implements code review feedback

    This commit implements some other code review feedback
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    f1c5591 View commit details
    Browse the repository at this point in the history
  26. Enable ErrorProne in extra

    Thi commit removes the `.*extras/src/test.*` path from the `-XepExcludedPaths` parameter of ErrorProne.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7590168 View commit details
    Browse the repository at this point in the history
  27. Fix the JavaUtilDate warns

    This commit fix all `JavaUtilDate` warns given by ErrorProne in the `extras/src/test.*` path.
    MaicolAntali committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1bb54c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Configuration menu
    Copy the full SHA
    a507512 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd2916e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Configuration menu
    Copy the full SHA
    13ab165 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7cca38 View commit details
    Browse the repository at this point in the history
  3. Revert "Adds JDK11 to run test with --release 11"

    This reverts commit a7cca38.
    MaicolAntali committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5dbbbee View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Configuration menu
    Copy the full SHA
    f89d42a View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Configuration menu
    Copy the full SHA
    039bf62 View commit details
    Browse the repository at this point in the history