-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error prone warns #2320
Fix error prone warns #2320
Commits on Feb 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 18336d0 - Browse repository at this point
Copy the full SHA 18336d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c2f8c3 - Browse repository at this point
Copy the full SHA 0c2f8c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f64bf3 - Browse repository at this point
Copy the full SHA 7f64bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f34c35d - Browse repository at this point
Copy the full SHA f34c35dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e6a279 - Browse repository at this point
Copy the full SHA 5e6a279View commit details -
Configuration menu - View commit details
-
Copy full SHA for 682b369 - Browse repository at this point
Copy the full SHA 682b369View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41e0c28 - Browse repository at this point
Copy the full SHA 41e0c28View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6965d1 - Browse repository at this point
Copy the full SHA b6965d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04feff6 - Browse repository at this point
Copy the full SHA 04feff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd180d - Browse repository at this point
Copy the full SHA 5bd180dView commit details
Commits on Feb 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 373525d - Browse repository at this point
Copy the full SHA 373525dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd60abf - Browse repository at this point
Copy the full SHA bd60abfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e1e970 - Browse repository at this point
Copy the full SHA 5e1e970View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3c4763 - Browse repository at this point
Copy the full SHA f3c4763View commit details -
Excludes from
proto
just the generated code.Replaces `.*proto.*` with `.*/generated-test-sources/protobuf/.*` in such way will be excluded just the generated code and not the whole `proto` directory
Configuration menu - View commit details
-
Copy full SHA for 71a75b8 - Browse repository at this point
Copy the full SHA 71a75b8View commit details -
Removes the `descriptor` variable because is unused.
Configuration menu - View commit details
-
Copy full SHA for a1beaf2 - Browse repository at this point
Copy the full SHA a1beaf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c5073f - Browse repository at this point
Copy the full SHA 9c5073fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aad0bc - Browse repository at this point
Copy the full SHA 2aad0bcView commit details -
Enables ErrorProne in
gson/src/test.*
Removes the `gson/src/test.*` path from the `-XepExcludedPaths` parameter of the ErrorProne plugin
Configuration menu - View commit details
-
Copy full SHA for ba27715 - Browse repository at this point
Copy the full SHA ba27715View commit details -
This commit fix all `UnusedVariable` warns given by ErrorProne in the `gson/src/test.*` path. Some field is annotated with `@Keep` that means is used by reflection. In some other case the record is annotated with `@SuppressWarnings("unused")`
Configuration menu - View commit details
-
Copy full SHA for e3d65bc - Browse repository at this point
Copy the full SHA e3d65bcView commit details -
This commit fix all `JavaUtilDate` warns given by ErrorProne in the `gson/src/test.*` path. Classes/Methods are annotated with `@SuppressWarnings("JavaUtilDate")` because it's not possible use differente Date API.
Configuration menu - View commit details
-
Copy full SHA for d1c0554 - Browse repository at this point
Copy the full SHA d1c0554View commit details -
This commit fix all `EqualsGetClass` warns given by ErrorProne in the `gson/src/test.*` path. I have rewrite the `equals()` methods to use `instanceof`
Configuration menu - View commit details
-
Copy full SHA for 7769c75 - Browse repository at this point
Copy the full SHA 7769c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8cff33 - Browse repository at this point
Copy the full SHA a8cff33View commit details
Commits on Feb 22, 2023
-
This commit fix all `JdkObsolete` warns given by ErrorProne in the `gson/src/test.*` path. In some cases I have replaced the obsolete JDK classes with the newest alternatives. In other cases, I have added the `@SuppressWarnings("JdkObsolete")`
Configuration menu - View commit details
-
Copy full SHA for eb05e0d - Browse repository at this point
Copy the full SHA eb05e0dView commit details -
This commit fix all `ClassCanBeStatic` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `static` keyword, or I have added `@SuppressWarnings("ClassCanBeStatic")`
Configuration menu - View commit details
-
Copy full SHA for ef27eb4 - Browse repository at this point
Copy the full SHA ef27eb4View commit details -
This commit fix all `UndefinedEquals` warns given by ErrorProne in the `gson/src/test.*` path. I have added `@SuppressWarnings("UndefinedEquals")` or fixed the asserts Note: In this commit I have also renamed a test from `testRawCollectionDeserializationNotAlllowed` to `testRawCollectionDeserializationNotAllowed`
Configuration menu - View commit details
-
Copy full SHA for 69b34be - Browse repository at this point
Copy the full SHA 69b34beView commit details -
This commit fix all `GetClassOnEnum` warns given by ErrorProne in the `gson/src/test.*` path. I have replaced the `.getClass()` with `.getDeclaringClass()`
Configuration menu - View commit details
-
Copy full SHA for 7a20385 - Browse repository at this point
Copy the full SHA 7a20385View commit details -
Fixes
ImmutableEnumChecker
warnsThis commit fix all `ImmutableEnumChecker` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `final` keyword, or I have added the `@SuppressWarnings("ImmutableEnumChecker")` annotation
Configuration menu - View commit details
-
Copy full SHA for 4627307 - Browse repository at this point
Copy the full SHA 4627307View commit details -
Fixes
StaticAssignmentOfThrowable
warnsThis commit fix all `StaticAssignmentOfThrowable` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 13de98d - Browse repository at this point
Copy the full SHA 13de98dView commit details -
Fixes
AssertionFailureIgnored
warnsThis commit fix all `AssertionFailureIgnored` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `@SuppressWarnings("AssertionFailureIgnored")` annotation
Configuration menu - View commit details
-
Copy full SHA for 3ae4fac - Browse repository at this point
Copy the full SHA 3ae4facView commit details -
Fixes
ModifiedButNotUsed
warnsThis commit fix all `ModifiedButNotUsed` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `@SuppressWarnings("ModifiedButNotUsed")` annotation
Configuration menu - View commit details
-
Copy full SHA for 661eae8 - Browse repository at this point
Copy the full SHA 661eae8View commit details -
This commit fix all `MissingSummary` warns given by ErrorProne in the `gson/src/test.*` path. I have remove the Javadoc `@author`
Configuration menu - View commit details
-
Copy full SHA for 2742881 - Browse repository at this point
Copy the full SHA 2742881View commit details -
Fixes
FloatingPointLiteralPrecision
warnsThis commit fix all `FloatingPointLiteralPrecision` warns given by ErrorProne in the `gson/src/test.*` path. I have added the `@SuppressWarnings("FloatingPointLiteralPrecision")` annotation
Configuration menu - View commit details
-
Copy full SHA for 7d688ed - Browse repository at this point
Copy the full SHA 7d688edView commit details -
This commit fix all `StringSplitter` warns given by ErrorProne in the `gson/src/test.*` path. I have replaced the `String.split(...)` with `Splitter`
Configuration menu - View commit details
-
Copy full SHA for 67a8edf - Browse repository at this point
Copy the full SHA 67a8edfView commit details -
This commit fix all `EmptyCatch` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for b92cb96 - Browse repository at this point
Copy the full SHA b92cb96View commit details -
This commit fix all `UnicodeEscape` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for dcb277e - Browse repository at this point
Copy the full SHA dcb277eView commit details -
This commit fix all `EmptyBlockTag` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 6dee398 - Browse repository at this point
Copy the full SHA 6dee398View commit details -
Fixes
LongFloatConversion
warnsThis commit fix all `LongFloatConversion` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 682d5df - Browse repository at this point
Copy the full SHA 682d5dfView commit details -
Fixes
LongDoubleConversion
warnsThis commit fix all `LongDoubleConversion` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for c1681bf - Browse repository at this point
Copy the full SHA c1681bfView commit details -
Fixes
TruthAssertExpected
warnsThis commit fix all `TruthAssertExpected` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 69dcd03 - Browse repository at this point
Copy the full SHA 69dcd03View commit details -
This commit fix all `UnusedMethod` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 03e86d6 - Browse repository at this point
Copy the full SHA 03e86d6View commit details -
Fixes
UnusedTypeParameter
warnsThis commit fix all `UnusedTypeParameter` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 1feefb4 - Browse repository at this point
Copy the full SHA 1feefb4View commit details -
This commit fix all `CatchFail` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 7ac4465 - Browse repository at this point
Copy the full SHA 7ac4465View commit details -
Fixes
MathAbsoluteNegative
warnsThis commit fix all `MathAbsoluteNegative` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 92972bf - Browse repository at this point
Copy the full SHA 92972bfView commit details -
This commit fix all `LoopOverCharArray` warns given by ErrorProne in the `gson/src/test.*` path. `toCharArray` allocates a new array, using `charAt` is more efficient
Configuration menu - View commit details
-
Copy full SHA for 2167d4c - Browse repository at this point
Copy the full SHA 2167d4cView commit details -
This commit fix all `HidingField` warns given by ErrorProne in the `gson/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 126b1b5 - Browse repository at this point
Copy the full SHA 126b1b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aaefea - Browse repository at this point
Copy the full SHA 4aaefeaView commit details -
Implements code review feedback
This commit implements some other code review feedback
Configuration menu - View commit details
-
Copy full SHA for f1c5591 - Browse repository at this point
Copy the full SHA f1c5591View commit details -
Thi commit removes the `.*extras/src/test.*` path from the `-XepExcludedPaths` parameter of ErrorProne.
Configuration menu - View commit details
-
Copy full SHA for 7590168 - Browse repository at this point
Copy the full SHA 7590168View commit details -
This commit fix all `JavaUtilDate` warns given by ErrorProne in the `extras/src/test.*` path.
Configuration menu - View commit details
-
Copy full SHA for 1bb54c4 - Browse repository at this point
Copy the full SHA 1bb54c4View commit details
Commits on Feb 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a507512 - Browse repository at this point
Copy the full SHA a507512View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd2916e - Browse repository at this point
Copy the full SHA bd2916eView commit details
Commits on Feb 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 13ab165 - Browse repository at this point
Copy the full SHA 13ab165View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7cca38 - Browse repository at this point
Copy the full SHA a7cca38View commit details -
Revert "Adds
JDK11
to run test with--release 11
"This reverts commit a7cca38.
Configuration menu - View commit details
-
Copy full SHA for 5dbbbee - Browse repository at this point
Copy the full SHA 5dbbbeeView commit details
Commits on Feb 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f89d42a - Browse repository at this point
Copy the full SHA f89d42aView commit details
Commits on Mar 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 039bf62 - Browse repository at this point
Copy the full SHA 039bf62View commit details