Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error prone warns #2320
Fix error prone warns #2320
Changes from all commits
18336d0
0c2f8c3
7f64bf3
f34c35d
5e6a279
682b369
41e0c28
b6965d1
04feff6
5bd180d
373525d
bd60abf
5e1e970
f3c4763
71a75b8
a1beaf2
9c5073f
2aad0bc
ba27715
e3d65bc
d1c0554
7769c75
a8cff33
eb05e0d
ef27eb4
69b34be
7a20385
4627307
13de98d
3ae4fac
661eae8
2742881
7d688ed
67a8edf
b92cb96
dcb277e
6dee398
682d5df
c1681bf
69dcd03
03e86d6
1feefb4
7ac4465
92972bf
2167d4c
126b1b5
4aaefea
f1c5591
7590168
1bb54c4
a507512
bd2916e
13ab165
a7cca38
5dbbbee
f89d42a
039bf62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did Error Prone suggest changing the
getClass()
check into thisinstanceof
? I believe it is correct, but I had to study the code a bit to make sure. There is actually a subclass ofBagOfPrimitives
calledSubTypeOfBagOfPrimitives
inJsonTreeTest
which adds an extra field. But it doesn't overrideequals
and the test doesn't rely onequals
, so I think it is OK that an instance ofBagOfPrimitives
can now equal an instance ofSubTypeOfBagOfPrimitives
where it couldn't before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again this has subclasses (anonymous ones) in
ObjectTest
, but I don't think the change inequals
semantics matters.