Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CharMatcher.retainFrom(CharSequence) is never tested #6069

Closed
ogregoire opened this issue Jun 2, 2022 · 0 comments
Closed

CharMatcher.retainFrom(CharSequence) is never tested #6069

ogregoire opened this issue Jun 2, 2022 · 0 comments
Labels
P3 package=base status=triaged type=other Miscellaneous activities not covered by other type= labels

Comments

@ogregoire
Copy link

I just found out that CharMatcher.retainFrom(CharSequence), while having a very simple implementation, is not tested at all in the whole codebase.
rilmay pushed a commit to rilmay/guava that referenced this issue Jun 3, 2022
Added test for CharMatcher.retainFrom() method (issue google#6069)
3ab8d67
@chaoren chaoren added package=base status=triaged type=other Miscellaneous activities not covered by other type= labels P3 labels Jun 15, 2022
@konstantin-goldman konstantin-goldman mentioned this issue May 17, 2023
Closed
@copybara-service copybara-service bot mentioned this issue May 17, 2023
Closed
copybara-service bot pushed a commit that referenced this issue May 17, 2023
@konstantin-goldman
Add unit test for untested CharMatcher.retainFrom() method.
83aa3d2 
Fixes #6500
Fixes #6069

RELNOTES=n/a
PiperOrigin-RevId: 532876874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 package=base status=triaged type=other Miscellaneous activities not covered by other type= labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit test for untested CharMatcher.retainFrom() method. google/guava
2 participants
@ogregoire @chaoren