Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for CharMatcher.retainFrom() #6500

Closed
wants to merge 1 commit into from
Closed

Add test for CharMatcher.retainFrom() #6500

wants to merge 1 commit into from

Conversation

konstantin-goldman
Copy link
Contributor

Related to the following open issue: #6069

I wanted to close out the above ticket; this code provides a unit test for the currently untested CharMatcher.retainFrom() method.

Tested locally with mvn test:

Running com.google.common.base.CharMatcherTest
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.425 sec

@cpovirk cpovirk added package=base type=other Miscellaneous activities not covered by other type= labels status=in-progress P2 labels May 17, 2023
@cpovirk cpovirk self-assigned this May 17, 2023
@copybara-service copybara-service bot mentioned this pull request May 17, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request May 17, 2023
@konstantin-goldman
Add unit test for untested CharMatcher.retainFrom() method.
83aa3d2 
Fixes #6500
Fixes #6069

RELNOTES=n/a
PiperOrigin-RevId: 532876874
@cpovirk cpovirk mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpovirk cpovirk

Labels
P2 package=base status=in-progress type=other Miscellaneous activities not covered by other type= labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstantin-goldman @cpovirk