Make marquee text maintain talkback focus during marquee animation. #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
approved these changes
Mar 19, 2024
| @@ -100,6 +102,7 @@ public fun MarqueeText( | |||
| inlineContent = inlineContent, | |||
| modifier = modifier | |||
| .then(controller.outsideMarqueeModifier) | |||
| .semantics { focused = true } | |||
There was a problem hiding this comment.
Does this affect RSB at all?
There was a problem hiding this comment.
No, this only affects the talkback green frame focus. RSB works as it is, normally controls the volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Make marquee text maintain talkback focus during marquee animation.
WHY
Currently, when Talkback focuses on the marquee title, the marquee loses focus after completing its first round of animation.
HOW
Add
Modifier.semantics { focused = true }to the marquee text.Checklist 📋