Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make marquee text maintain talkback focus during marquee animation. #2148

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Make marquee text maintain talkback focus during marquee animation. #2148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions composables/src/main/java/com/google/android/horologist/composables/MarqueeText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.CompositingStrategy
import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.layout.layout
import androidx.compose.ui.semantics.focused
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.TextStyle
import androidx.compose.ui.text.style.TextAlign
Expand Down Expand Up @@ -100,6 +102,7 @@ public fun MarqueeText(
inlineContent = inlineContent,
modifier = modifier
.then(controller.outsideMarqueeModifier)
.semantics { focused = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect RSB at all?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this only affects the talkback green frame focus. RSB works as it is, normally controls the volume.

.basicMarquee(
iterations = Int.MAX_VALUE,
delayMillis = pauseTime.inWholeMilliseconds.toInt(),
Expand Down