-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build working Windows container images #374
Conversation
bd1a61f
to
2a47b11
Compare
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 43.43% 43.21% -0.23%
==========================================
Files 33 33
Lines 1570 1585 +15
==========================================
+ Hits 682 685 +3
- Misses 760 768 +8
- Partials 128 132 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! There's just saw a small issue with the Windows PATH
value that might simplify some things.
49ee391
to
c89757e
Compare
cd9870f
to
8094159
Compare
Add e2e tests that run on Windows and cover kodata behavior
Fixes #361
The main discoveries while implementing this have been:
Files/
root directory in the tar archiveHives/
root directory to be present, though it can be emptyPAXRecords
value to be executable at runtimeEven after this work lands, users building images will have to make sure they use a base image that provides the exact Windows OS version that they intend to run the image on. Users wishing to produce a multi-OS image with
ko
will probably also have to stitch together a suitable base image from nanoserver etc., and whatever Linux base image they want to use (distroless, alpine, etc.), since AFAIK suitable multi-OS base images aren't exactly prevalent in the wild.