Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build working Windows container images #374

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jun 9, 2021

Fixes #361

The main discoveries while implementing this have been:

  • Windows containers expect contents to be in a Files/ root directory in the tar archive
    • ...and for a Hives/ root directory to be present, though it can be empty
  • Executable entries in the tar archive must have a PAXRecords value to be executable at runtime

Even after this work lands, users building images will have to make sure they use a base image that provides the exact Windows OS version that they intend to run the image on. Users wishing to produce a multi-OS image with ko will probably also have to stitch together a suitable base image from nanoserver etc., and whatever Linux base image they want to use (distroless, alpine, etc.), since AFAIK suitable multi-OS base images aren't exactly prevalent in the wild.

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@imjasonh imjasonh marked this pull request as draft June 9, 2021 13:55
@imjasonh imjasonh force-pushed the windows branch 3 times, most recently from bd1a61f to 2a47b11 Compare June 9, 2021 14:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #374 (bbf7b92) into main (23ecf47) will decrease coverage by 0.22%.
The diff coverage is 58.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   43.43%   43.21%   -0.23%     
==========================================
  Files          33       33              
  Lines        1570     1585      +15     
==========================================
+ Hits          682      685       +3     
- Misses        760      768       +8     
- Partials      128      132       +4     
Impacted Files Coverage Δ
pkg/build/gobuild.go 58.08% <58.92%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ecf47...bbf7b92. Read the comment docs.

@imjasonh imjasonh marked this pull request as ready for review June 11, 2021 16:36
@imjasonh imjasonh changed the title WIP: Build working Windows container images Build working Windows container images Jun 11, 2021
Copy link

@micahyoung micahyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! There's just saw a small issue with the Windows PATH value that might simplify some things.

pkg/build/gobuild.go Show resolved Hide resolved
pkg/build/gobuild.go Outdated Show resolved Hide resolved
@imjasonh imjasonh force-pushed the windows branch 2 times, most recently from 49ee391 to c89757e Compare June 22, 2021 13:43
@imjasonh imjasonh force-pushed the windows branch 2 times, most recently from cd9870f to 8094159 Compare July 23, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ko-built Windows images aren't pullable/runnable
4 participants