Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix has_served_traffic safety check so it doesn't break notebook development #694

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Fix has_served_traffic safety check so it doesn't break notebook development #694

merged 4 commits into from
Jul 30, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Jul 30, 2024 •
edited
Loading

Notes:

  • extract colab_utils to utils so runtime can depend on it without a cycle

@wwwillchen wwwillchen changed the title Disable has_served_traffic safety checks for debug mode Disable has_served_traffic safety checks when running under Colab/iPython Jul 30, 2024
@wwwillchen wwwillchen changed the title Disable has_served_traffic safety checks when running under Colab/iPython Fix has_served_traffic safety check so it doesn't break notebook development Jul 30, 2024
@wwwillchen wwwillchen merged commit c0d2c4d into google:main Jul 30, 2024
3 checks passed
@wwwillchen wwwillchen deleted the fix-create-context branch July 30, 2024 17:00
wwwillchen added a commit to wwwillchen/mesop that referenced this pull request Jul 30, 2024
@wwwillchen
Fix google#694 - only check debug mode for has served traffic check
00618f7
wwwillchen added a commit that referenced this pull request Jul 30, 2024
@wwwillchen
Fix #694 - only check debug mode for has served traffic check (#696)
7db14bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwillchen @richard-to