Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix has_served_traffic safety check so it doesn't break notebook development #694

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Fix has_served_traffic safety check so it doesn't break notebook development #694

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef0ed77
Disable has_served_traffic safety checks for debug mode
wwwillchen Jul 30, 2024
22058c0
switch to detecting colab/ipython
wwwillchen Jul 30, 2024
f51b770
extract colab_utils to utils so runtime can depend on it without a cycle
wwwillchen Jul 30, 2024
89acf26
change the safety check
wwwillchen Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mesop/runtime/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ def context(self) -> Context:
return g._mesop_context

def create_context(self) -> Context:
self._has_served_traffic = True
# In debug mode, do not set _has_served_traffic to True,
# otherwise this breaks Colab / notebok use cases where users
# will want to register pages after traffic has been served.
if not self.debug_mode:
self._has_served_traffic = True
if len(self._state_classes) == 0:
states = {EmptyState: EmptyState()}
else:
Expand Down
Loading