Skip to content

Commit

Permalink
chore: limit to Node >=9.4.0 || >8.9.4 <9 (#4)
Browse files Browse the repository at this point in the history
* chore: limit to Node >=9.4.0 || >8.9.4 <9

There was a breaking change in http2 with Node 9.4.0. A similar change
will be made in Node 8 too.

Temporarily disable CircleCI tests with Node 8. And also update README
with the info.

* up the version to v0.2.0

* update h2-auto-push to 0.2.0
  • Loading branch information
jinwoo committed Jan 18, 2018
1 parent a9166dc commit a1ea9d9
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
18 changes: 9 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,25 @@ workflows:
version: 2
tests:
jobs:
- node8:
filters: *release_tags
# - node8:
# filters: *release_tags
- node9:
filters: *release_tags
- publish_npm:
requires:
- node8
# - node8
- node9
filters:
branches:
ignore: /.*/
<<: *release_tags

jobs:
node8:
docker:
- image: node:8
user: node
<<: *unit_tests
# node8:
# docker:
# - image: node:8
# user: node
# <<: *unit_tests
node9:
docker:
- image: node:9
Expand All @@ -50,7 +50,7 @@ jobs:

publish_npm:
docker:
- image: node:8
- image: node:9
user: node
steps:
- checkout
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ supports automatic server-push.

For more details, see the `h2-auto-push` package.

**This package currently works only with Node >=9.4.0.**

## How to use

```javascript
Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "fastify-auto-push",
"version": "0.1.1",
"version": "0.2.0",
"description": "HTTP/2 auto-push middleware for fastify",
"main": "build/src/index.js",
"types": "build/src/index",
Expand All @@ -22,6 +22,9 @@
"posttest": "npm run check && npm run license-check",
"license-check": "jsgl --local ."
},
"engines": {
"node": ">=9.4.0 || >8.9.4 <9"
},
"keywords": [
"http2",
"auto-push",
Expand All @@ -45,7 +48,7 @@
"cookie": "^0.3.1",
"fastify": "^0.39.1",
"fastify-plugin": "^0.2.1",
"h2-auto-push": "^0.1.0",
"h2-auto-push": "^0.2.0",
"send": "^0.16.1"
},
"devDependencies": {
Expand Down

0 comments on commit a1ea9d9

Please sign in to comment.