chore: limit to Node >=9.4.0 || >8.9.4 <9 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a breaking change in http2 with Node 9.4.0. A similar change will be made in Node 8 too. Temporarily disable CircleCI tests with Node 8. And also update README with the info.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 76.31% 76.31%
=======================================
Files 1 1
Lines 38 38
Branches 9 9
=======================================
Hits 29 29
Misses 9 9Continue to review full report at Codecov.
|
|
I'm releasing the new version together with this change. The draft release note is in the GitHub UI. |
ofrobots
approved these changes
Jan 18, 2018
|
You can land changes like these with a TBR. |
kjin
approved these changes
Jan 18, 2018
| - image: node:8 | ||
| user: node | ||
| <<: *unit_tests | ||
| # node8: |
There was a problem hiding this comment.
I think technically you don't need to disable this here, right?
There was a problem hiding this comment.
You're right! But I'll leave this as disabled just to make it more prominent :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change in http2 with Node 9.4.0. A similar change
will be made in Node 8 too.
Temporarily disable CircleCI tests with Node 8. And also update README
with the info.