Update sync-protocol.md to include SIGNINGID rule type #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of formatting changes, added SIGNINGID as a rule type
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mlw
suggested changes
Jul 25, 2023
Co-authored-by: Matt W <436037+mlw@users.noreply.github.com>
mlw
approved these changes
Jul 25, 2023
pmarkowsky
added a commit
that referenced
this pull request
Aug 21, 2023
Removes file_bundle_binary_count and file_bunde_hash from the Rule definition and examples These were accidentally added to the Rule definition and examples, rather than to the Event section in #1130. Co-authored-by: Pete Markowsky <pmarkowsky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of formatting changes, added SIGNINGID as a rule type