Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to sync-protocol.md #1159

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Correction to sync-protocol.md #1159

merged 3 commits into from
Aug 21, 2023

Conversation

p-harrison
Copy link
Contributor

I think file_bundle_binary_count and file_bunde_hash were accidentally added to the Rule definition and examples, rather than to the Event section, so I propose moving them.

I think file_bundle_binary_count and file_bunde_hash were accidentally added to the Rule definition and examples, rather than to the Event section, so I propose moving them.
@p-harrison p-harrison requested a review from a team as a code owner August 21, 2023 12:25
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@pmarkowsky pmarkowsky merged commit 0400e29 into google:main Aug 21, 2023
2 checks passed
@pmarkowsky pmarkowsky added the docs Documentation-related issues label Aug 25, 2023
@pmarkowsky pmarkowsky added this to the 2023.8 Release milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants