Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore file_bundle_hash & file_bundle_binary_count to Sync Protocol Docs #1164

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

pmarkowsky
Copy link
Contributor

Restore file_bundle_hash and file_bundle_binary_count to docs that were mistakenly removed in #1159.

They're used in `SNTSyncRuleDownload's

- (void)processBundleNotificationsForRule:(SNTRule *)rule fromDictionary:(NSDictionary *)dict {

@pmarkowsky pmarkowsky added docs Documentation-related issues sync service Issues related to the sync service / protocol labels Aug 25, 2023
@pmarkowsky pmarkowsky requested a review from a team as a code owner August 25, 2023 12:23
@pmarkowsky pmarkowsky added this to the 2023.8 Release milestone Aug 25, 2023
@p-harrison
Copy link
Contributor

p-harrison commented Aug 25, 2023

@pmarkowsky sorry for leading you astray with my correction. Do you mind me asking what these two keys are used for in a rule? My understanding of bundle processing from the documentation is that its purpose is to scan a bundle and create Events for all binaries in that bundle, so when permitting a new bundle the administrator can 'get ahead' of the other binaries that will be blocked once the first to trigger a block is allowed. But there's obviously a bit more going on based on that code you linked to?
Sorry I'm not a developer so cannot figure it out myself from the code. I'm happy to contribute by documenting it though if I understand it.

@pmarkowsky
Copy link
Contributor Author

@p-harrison This was my fault for not double checking the code first.

This is used to trigger notifications for bundles so we can send notifications to users like foo.app is unblocked.

@pmarkowsky pmarkowsky merged commit 16a8c65 into google:main Aug 25, 2023
2 checks passed
@pmarkowsky pmarkowsky deleted the markowsky/fix-sync-docs branch August 25, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation-related issues sync service Issues related to the sync service / protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants