cpplint: Make six-compatible for Python3 #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hup, just saw #349, which accomplishes what this does without Would be great to see that land. Will leave open until that PR lands or a maintainer closes this issue. |
|
@EricCousineau-TRI : I don't think anyone at Google has time to look at PRs, let alone merge them. Consider the fork at https://github.com/cpplint/cpplint (also published to Pypi) if you feel like contributing. |
|
@tkruse is the fork active? |
|
@felker : Somewhat. Don't expect much to move on it's own, but if you make a PR, and prod a bit, a new version will be released on pypi. |
|
Gotcha, will file an issue on our side and see if we can update to use the fork for linting - thanks! (And sorry for the late response!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream version of RobotLocomotion#13
This uses
six, which may inject additional dependencies on downstream projects.If so desired, I can rework it to be free of
six.This change is