-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add targets for writing GDS files #1031
Conversation
936f202
to
f4d64f0
Compare
9639d6b
to
1222858
Compare
PR is ready for review, I've updated the description. @proppy please take a look. |
dependency_support/embedded_python_interpreter/print_libpython_path.py
Outdated
Show resolved
Hide resolved
xls/examples/klayout.lyt
Outdated
@@ -0,0 +1,158 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the actual upstream is https://github.com/efabless/sky130_klayout_pdk/blob/main/sky130_tech/tech/sky130/sky130.lyt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a part of this PR anymore. It was added here only for testing purpose on the early stage of development.
It could be removed because KLayout tech files can now be supplied in bazel_rules_hdl
with hdl/bazel_rules_hdl@5e2ec27
hdl/bazel_rules_hdl#173 is merged. I bumped bazel_rules_hdl dependency, rebased the code and fixed the commit history. @proppy this PR is ready for review again, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits, can you also mention in the description that this also add the rules for the rle
example?
744075c
to
67183e5
Compare
@proppy Sorry for the delay, I addressed your comments: renamed the rules and updated PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit.
xls/examples/BUILD
Outdated
@@ -32,6 +32,7 @@ load( | |||
load("@rules_hdl//verilog:providers.bzl", "verilog_library") | |||
load("@rules_hdl//synthesis:build_defs.bzl", "synthesize_rtl") | |||
load("@rules_hdl//place_and_route:build_defs.bzl", "place_and_route") | |||
load("@rules_hdl//gds_write:build_defs.bzl", "gds_write") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Load statement is out of its lexicographical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
load("@rules_hdl//verilog:providers.bzl", "verilog_library") | ||
load("@rules_hdl//synthesis:build_defs.bzl", "synthesize_rtl") | ||
load("@rules_hdl//place_and_route:build_defs.bzl", "place_and_route") | ||
load("@rules_hdl//gds_write:build_defs.bzl", "gds_write") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Load statement is out of its lexicographical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Fixed the load statements order and rebased the code onto 4c05344 |
Note: the internal review is currently blocked by a bazel_rules_hdl import (#ref 566360201) |
511e9fc
to
72958fa
Compare
Builds fail on GDS generation with:
This is caused by eb2fb6d. I was able to fix the build locally by changing the python version from |
eb2fb6d does pass the python interpreter target here: https://github.com/google/xls/blob/main/dependency_support/initialize_external.bzl#L37 but also set the version to Do you have more logging from bazel when |
52db084
to
4becdd3
Compare
Hi @proppy, I was actually able to fix this issue by fixing hermetic python handling in In this PR for the sake of testing my changes I've added a temporary commit which changes the source of bazel_rules_hdl to branch from the linked PR. I will change it to bumping bazel_rules_hdl version once hdl/bazel_rules_hdl#240 is merged. |
Generate GDS for process technologies: * ASAP7 * SKY130 Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Add GDS write examples for RLE encoder and decoder for process technologies: * ASAP7 * SKY130 Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Closes #1024
This PR bumps
bazel_rules_hdl
in order to:gds_write
rule for writing GDS files (see Add rule for writing GDS files hdl/bazel_rules_hdl#169).Additionally:
find_index
example based on the results from previousplace_and_route
targets for ASAP7 and SKY130 technologies.RLE
encoder and decoder examples, also for ASAP7 and SKY130.EDIT:
This PR depends on #1230