pdk: open_road_configuration: Get KLayout technology file and metal fill configuration from internal PDK setup #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
proppy
reviewed
Jul 24, 2023
| @@ -59,6 +59,7 @@ open_road_pdk_configuration( | |||
| "M7": "0.5", | |||
| }, | |||
| global_routing_signal_layers = "M2-M7", | |||
| klayout_tech_file = "@rules_hdl//dependency_support/org_theopenroadproject_asap7:asap7.lyt", | |||
There was a problem hiding this comment.
q: no fill config by default in ASAP7?
There was a problem hiding this comment.
Looking at the flow examples in OpenROAD-flow-scripts - no, there is no density_fill stage in the flow targeting ASAP7 so there is no need for specifying the config file
|
Hi @QuantamHD, please take a look at this PR. Merging this would unblock our work in google/xls#1031 |
QuantamHD
approved these changes
Jul 27, 2023
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies open_road_configuration so that it is now possible for a PDK dependency to define additional two fields:
The last one is required for GDS configuration so this field was marked as mandatory. The files are used by rules:
place_and_routeandgds_write. Default values specified for each PDK can be overwritten by attributesdensity_configandklayout_lytof those rules.It is reasonable to move handling of those files to the PDK dependencies setup because these are PDK-specific and can be reused for multiple designs.
CC @proppy