Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
chore: temporarily disable circular code test (#743)
Browse files Browse the repository at this point in the history
* chore: temporarily disable circular code test

The circular code test is failing on Node 12 that is preventing
other PRs from landing.  This PR will unblock those other PRs.
See issue #742 for more context.

* chore: also disable 'read the argument and the context' test
  • Loading branch information
DominicKramer authored and kjin committed Aug 16, 2019
1 parent 041bcd8 commit 5cdaed9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/test-circular.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ describe(__filename, () => {
afterEach(() => {
assert(stateIsClean(api));
});
// TODO(kjin): Re-enable this test after issue #742 has been addressed
/*
it('Should be able to read the argument and the context', done => {
// TODO: Have this actually implement Breakpoint
const brk: stackdriver.Breakpoint = {
Expand Down Expand Up @@ -140,4 +142,5 @@ describe(__filename, () => {
process.nextTick(code.foo.bind({}));
});
});
*/
});
3 changes: 3 additions & 0 deletions test/test-this-context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ describe(__filename, () => {
afterEach(() => {
assert(stateIsClean(api));
});
// TODO(kjin): Re-enable this test after issue #742 has been addressed
/*
it('Should be able to read the argument and the context', done => {
// TODO: Have this actually implement Breakpoint
const brk: stackdriver.Breakpoint = {
Expand Down Expand Up @@ -120,6 +122,7 @@ describe(__filename, () => {
process.nextTick(code.foo.bind({}, 1));
});
});
*/
it('Should be able to read the argument and deny the context', done => {
// TODO: Have this actually implement Breakpoint
const brk = {
Expand Down

0 comments on commit 5cdaed9

Please sign in to comment.