This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Remove duplicate isDisabled logic from controller #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debuglet also has the same isDisabled check. Arguably the controller shouldn't be doing this check at all because we do get a valid debuggee.id back from the service and we should faithfully report that to the client of the Controller interface. Business logic to deal with a disabled debuggee belongs in the agent.
googlebot
added
the
cla: yes
matthewloring
approved these changes
Dec 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debuglet also has the same isDisabled check. Arguably the
controller shouldn't be doing this check at all because we do get a
valid debuggee.id back from the service and we should faithfully
report that to the client of the Controller interface. Business logic
to deal with a disabled debuggee belongs in the agent.