Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Remove duplicate isDisabled logic from controller #206

Merged
merged 1 commit into from
Dec 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ Controller.prototype.register = function(debuggee, callback) {
new Error('unable to register, statusCode ' + response.statusCode));
} else if (!body.debuggee) {
callback(new Error('invalid response body from server'));
} else if (body.debuggee.isDisabled) {
callback('Debuggee is disabled on server');
} else {
debuggee.id = body.debuggee.id;
callback(null, body);
Expand Down
44 changes: 22 additions & 22 deletions test/test-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,28 +95,28 @@ describe('Controller API', function() {
});
});

it('should return error when debuggee is disabled', function(done) {
var scope = nock(url)
.post(api + '/debuggees/register')
.reply(200, {
debuggee: {
id: 'fake-debuggee',
isDisabled: true
},
activePeriodSec: 600,
});
var debuggee = new Debuggee({
project: 'fake-project',
uniquifier: 'fake-id',
description: 'unit test'
});
var controller = new Controller(fakeDebug);
controller.register(debuggee, function(err/*, result*/) {
assert(err, 'expected an error');
scope.done();
done();
});
});
it('should not return an error when the debuggee isDisabled',
function(done) {
var scope = nock(url)
.post(api + '/debuggees/register')
.reply(200, {
debuggee: {id: 'fake-debuggee', isDisabled: true},
activePeriodSec: 600,
});
var debuggee = new Debuggee({
project: 'fake-project',
uniquifier: 'fake-id',
description: 'unit test'
});
var controller = new Controller(fakeDebug);
controller.register(debuggee, function(err, result) {
assert.ifError(err, 'not expected an error');
assert.equal(result.debuggee.id, 'fake-debuggee');
assert.ok(result.debuggee.isDisabled);
scope.done();
done();
});
});

});

Expand Down