-
Notifications
You must be signed in to change notification settings - Fork 51
fix: use stableObjectId field for object equality in Node 10+ #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I would suggest adding a test to ensure the warning message you added is displayed under and only under the conditions in which it should be displayed.
Just a note, we should not land this yet since the method for getting stable object ID will change. Once the functionality is committed to V8, I will provide an update. |
d17da40
to
ca9c7f3
Compare
This fix should work once this is landed on v10/v11: nodejs/node#23886 |
@kjin Is this PR ready to land? |
@DominicKramer Not yet, see my previous comment. The PR has to get merged first, then backported to v10/v11, and then released. |
@kjin What is the status on this? |
696e1b7
to
d6600e6
Compare
This is blocked on release of Node |
@googleapis/node-team This is finally ready to re-review and land, now that 10.15.3 is out. PTAL. |
Is this really still blocked? |
@JustinBeckwith I guess it is not now. When I set the blocked label I didn't see Kelvin's last comment. |
This allows us to properly represent objects with circular references in Node 10+, unless
capture.maxDataSize=0
, which will only be fixed oncestableObjectId
is introduced in Node 10. See #516