Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] deps: cherry-pick d9fbfeb from upstream V8 #25330

Closed
wants to merge 1 commit into from

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jan 3, 2019

Original commit message:

inspector: return [[StableObjectId]] as internal property

This property might be useful for fast '===' check.

R=dgozman@chromium.org,yangguo@chromium.org

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}

See: #23886

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 3, 2019
@kjin
Copy link
Contributor Author

kjin commented Jan 14, 2019

@ofrobots Seems like the CI failure is an unrelated flake: https://ci.nodejs.org/job/node-test-binary-windows/22973/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/

I've rebased to resolve conflicts in common.gypi.

@ofrobots
Copy link
Contributor

The CI looks good to me. @nodejs/backporters this is ready to land.

@ofrobots ofrobots added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2019
@codebytere codebytere force-pushed the v10.x-staging branch 3 times, most recently from 2d6e145 to 7840f71 Compare January 29, 2019 18:12
@kjin
Copy link
Contributor Author

kjin commented Jan 31, 2019

@nodejs/backporters -- could we land this please? Thanks!

@ofrobots
Copy link
Contributor

ofrobots commented Feb 1, 2019

@nodejs/release @nodejs/backporters does the policy that only the backport team should be landing fixes on staging branches still make sense? Perhaps that is unnecessary burden on the team, and we should open this ability up to a broader list of collaborators to ensure things don't get stuck. Similarly: #25242.

@richardlau
Copy link
Member

@nodejs/release @nodejs/backporters does the policy that only the backport team should be landing fixes on staging branches still make sense? Perhaps that is unnecessary burden on the team, and we should open this ability up to a broader list of collaborators to ensure things don't get stuck. Similarly: #25242.

Discussion over in nodejs/Release#388.

@BethGriggs
Copy link
Member

Could we get a review from @nodejs/v8?, then this should land ready for v10.15.2

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There were also LGTMs on #23886.
EDIT: launched a new CI: https://ci.nodejs.org/job/node-test-pull-request/20566/

Original commit message:

    inspector: return [[StableObjectId]] as internal property

    This property might be useful for fast '===' check.

    R=dgozman@chromium.org,yangguo@chromium.org

    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
    Reviewed-on: https://chromium-review.googlesource.com/1226411
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56095}
@kjin
Copy link
Contributor Author

kjin commented Feb 4, 2019

Force-pushed to edit the commit message once again, seems like quoted commits need to be spaced 4 whitespaces instead of two.

@BethGriggs
Copy link
Member

BethGriggs commented Feb 5, 2019

Landed on v10.x-staging in c9a3e40

@BethGriggs BethGriggs closed this Feb 5, 2019
BethGriggs pushed a commit that referenced this pull request Feb 5, 2019
Original commit message:

    inspector: return [[StableObjectId]] as internal property

    This property might be useful for fast '===' check.

    R=dgozman@chromium.org,yangguo@chromium.org

    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
    Reviewed-on: https://chromium-review.googlesource.com/1226411
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56095}

PR-URL: #25330
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Original commit message:

    inspector: return [[StableObjectId]] as internal property

    This property might be useful for fast '===' check.

    R=dgozman@chromium.org,yangguo@chromium.org

    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
    Reviewed-on: https://chromium-review.googlesource.com/1226411
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56095}

PR-URL: #25330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants