This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
feat: add get()
function
#709
Merged
DominicKramer
merged 3 commits into
googleapis:master
from
DominicKramer:feat/add-get-function
Jun 5, 2019
Merged
feat: add get()
function
#709
DominicKramer
merged 3 commits into
googleapis:master
from
DominicKramer:feat/add-get-function
Jun 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
May 28, 2019
PR #710 is blocking this PR as it should address the test failures. |
DominicKramer
added
the
status: blocked
Resolving the issue is dependent on other work.
label
May 28, 2019
ofrobots
approved these changes
May 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green.
JustinBeckwith
removed
the
status: blocked
Resolving the issue is dependent on other work.
label
May 29, 2019
DominicKramer
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 29, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 29, 2019
Merged
This is blocked by PR #713 |
DominicKramer
added
the
status: blocked
Resolving the issue is dependent on other work.
label
May 31, 2019
This is also blocked by PR #718. After that lands, the tests will pass. |
The `get()` function is used to access an agent if it has been started.
DominicKramer
force-pushed
the
feat/add-get-function
branch
from
June 5, 2019 16:58
b1ae5a1
to
c25a34a
Compare
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 85.63% 85.66% +0.03%
==========================================
Files 13 13
Lines 947 949 +2
Branches 193 193
==========================================
+ Hits 811 813 +2
Misses 75 75
Partials 61 61
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
This human has signed the Contributor License Agreement.
status: blocked
Resolving the issue is dependent on other work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get()
function is used to access an agent if ithas been started.