This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
chore: merge options.debug
and options
#718
Merged
DominicKramer
merged 8 commits into
googleapis:master
from
DominicKramer:chore/merge-options.debug-and-options
Jun 5, 2019
Merged
chore: merge options.debug
and options
#718
DominicKramer
merged 8 commits into
googleapis:master
from
DominicKramer:chore/merge-options.debug-and-options
Jun 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `options` object given to the `start()` function has a debug property then, previously, the options used would be `options.debug`. Thus anything set in `options` itself, such as the `projectId` would not be used by the agent. This change suggests using the merger of `options` and `options.debug`.
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
May 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 85.56% 85.63% +0.07%
==========================================
Files 13 13
Lines 942 947 +5
Branches 193 193
==========================================
+ Hits 806 811 +5
Misses 75 75
Partials 61 61
Continue to review full report at Codecov.
|
kjin
reviewed
May 31, 2019
|
||
/** | ||
* If the given `options` object has a `debug` property | ||
* of the same type, this function returns the union of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should document which one takes precedence if both objects have identically named members, here and anywhere else where the debug
field is referenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
DominicKramer
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 1, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 1, 2019
…minicKramer/cloud-debug-nodejs into chore/merge-options.debug-and-options
DominicKramer
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2019
DominicKramer
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2019
kjin
approved these changes
Jun 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
options
object given to thestart()
function has adebug property then, previously, the options used would be
options.debug
. Thus anything set inoptions
itself, suchas the
projectId
would not be used by the agent. Thischange suggests using the merger of
options
andoptions.debug
.