This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
chore: merge options.debug
and options
#718
Merged
DominicKramer
merged 8 commits into
googleapis:master
from
DominicKramer:chore/merge-options.debug-and-options
Jun 5, 2019
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cbe410e
chore: merge `options.debug` and `options`
DominicKramer 5a225f4
chore: add the `mergeConfigs()` function
DominicKramer 734f839
chore: remove a redundant type annotation
DominicKramer 60ad092
chore: add documentation
DominicKramer 21ba8c1
Merge branch 'master' into chore/merge-options.debug-and-options
DominicKramer 8ea5900
Merge branch 'master' into chore/merge-options.debug-and-options
JustinBeckwith 6482fb4
chore: address github comments
DominicKramer c900cac
Merge branch 'chore/merge-options.debug-and-options' of github.com:Do…
DominicKramer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should document which one takes precedence if both objects have identically named members, here and anywhere else where the
debug
field is referenced.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done