feat: add support for Node 14 #709
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 7 7
Lines 1208 1208
Branches 97 97
=======================================
Hits 1039 1039
Misses 169 169 Continue to review full report at Codecov.
|
| @@ -11,7 +11,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node: [10, 12, 13] | |||
| node: [10, 12, 13, 14] | |||
There was a problem hiding this comment.
As part of this, maybe we could remove 13, and add 15? Or separate PRs?
There was a problem hiding this comment.
I'll probably do this in separate PR.
I'm mainly adding this PR to reflect that the pprof dependency now has node 14 pre-built binaries (and so, I want our next release to be a minor version bump and the Node 14 binaries to be noted in its release notes); but our transition in updating tests for pprof-nodejs with the Node 14 release was interrupted by work to fix the memory leak, so pprof-nodejs's testing is quite to the point where we should add node 14 support here.
No description provided.