chore(deps): upgrade pprof to v3.2.1 [security] #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 7 7
Lines 1253 1253
Branches 58 58
=======================================
Hits 863 863
Misses 389 389
Partials 1 1
☔ View full report in Codecov by Sentry. |
This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
aabmass
changed the title
psx95
approved these changes
Jul 24, 2023
aabmass
added a commit
that referenced
this pull request
Jul 24, 2023
aabmass
added a commit
to aabmass/cloud-profiler-nodejs
that referenced
this pull request
Jul 24, 2023
Fixes googleapis#879, take two of googleapis#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
aabmass
added a commit
that referenced
this pull request
Jul 24, 2023
Fixes #879, take two of #883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in #486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879
This upgrade caused an issue where the proto definitions in
protos/are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos withnpm run protos, however this fails because the third_party directory was removed in #486.To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused
protos/directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.